Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event for the default rule create hidden file or directory #103

Merged

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Mar 14, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for the default rule create hidden file or directory as mentioned here

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@GLVSKiriti
Copy link
Contributor Author

/area events

@GLVSKiriti
Copy link
Contributor Author

GLVSKiriti commented Mar 23, 2024

Similarly I tested it by enabling this rule in rules file as by default it is disabled. Producing notice log as expected on left terminal
createHiddenDirectory

@GLVSKiriti GLVSKiriti requested a review from leogr March 25, 2024 17:49
@GLVSKiriti GLVSKiriti force-pushed the create_hidden_files_or_directories branch from cd76808 to f033f7a Compare March 26, 2024 06:58
@poiana
Copy link

poiana commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 26, 2024

LGTM label has been added.

Git tree hash: f0225e91af3cb48dbf8c44a1995543bd6183f9d8

@poiana poiana merged commit ade98bb into falcosecurity:main Mar 26, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the create_hidden_files_or_directories branch March 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants