generated from falcosecurity/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added event for default stable rule "Remove Bulk Data from Disk" #109
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8023401
Added event for default stable rule remove bulk data from disk
GLVSKiriti a479ae9
Clean up the temp directory
GLVSKiriti da107c6
Update remove_bulk_data_from_disk.go
GLVSKiriti dc6cac1
Shred a file instead of directory
GLVSKiriti 97283da
Added comments for explaination
GLVSKiriti af195e1
Updated comments
GLVSKiriti 7a390e9
No need to return error and updated comments
GLVSKiriti b24782e
fix(events/syscall/remove_bulk_data_from_disk): no new variables on l…
leogr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
/* | ||
Copyright (C) 2024 The Falco Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package syscall | ||
|
||
import ( | ||
"os" | ||
"os/exec" | ||
"path/filepath" | ||
|
||
"github.com/falcosecurity/event-generator/events" | ||
) | ||
|
||
var _ = events.Register(RemoveBulkDataFromDisk) | ||
|
||
func RemoveBulkDataFromDisk(h events.Helper) error { | ||
// Creates temporary data for testing, avoiding critical file deletion. | ||
tmpDir, err := os.MkdirTemp(os.TempDir(), "created-by-falco-event-generator") | ||
if err != nil { | ||
return err | ||
} | ||
|
||
filename := filepath.Join(tmpDir, "file.txt") | ||
if err := os.WriteFile(filename, []byte("bulk data content"), os.FileMode(0755)); err != nil { | ||
return err | ||
} | ||
|
||
// Generating the event | ||
const command = "shred" | ||
h.Log().Infof("attempting to run %s command to remove bulk data from disk", command) | ||
cmd := exec.Command("shred", "-u", tmpDir) | ||
GLVSKiriti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
err = cmd.Run() | ||
return err | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leogr why again defer os.RemoveAll(tmpDir) as we already removing it with shred command in the same code at last
event-generator/events/syscall/remove_bulk_data_from_disk.go
Lines 42 to 44 in da107c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not consider that, you're likely right.
Just one doubt: what happens if
shred
fails? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irrespective of shred exist or not ! the rule is triggering in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here mkfs utility is not there in my system. Also the rule is triggering irrespective of utility existence