Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event for default stable rule "Remove Bulk Data from Disk" #109

Merged
merged 8 commits into from
Mar 26, 2024
45 changes: 45 additions & 0 deletions events/syscall/remove_bulk_data_from_disk.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package syscall

import (
"os"
"os/exec"
"path/filepath"

"github.com/falcosecurity/event-generator/events"
)

var _ = events.Register(RemoveBulkDataFromDisk)

func RemoveBulkDataFromDisk(h events.Helper) error {
// Creates temporary data for testing, avoiding critical file deletion.
tmpDir, err := os.MkdirTemp(os.TempDir(), "created-by-falco-event-generator")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tmpDir, err := os.MkdirTemp(os.TempDir(), "created-by-falco-event-generator")
tmpDir, err := os.MkdirTemp(os.TempDir(), "created-by-falco-event-generator")
defer os.RemoveAll(tmpDir) // clean up

Copy link
Contributor Author

@GLVSKiriti GLVSKiriti Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leogr why again defer os.RemoveAll(tmpDir) as we already removing it with shred command in the same code at last

cmd := exec.Command("shred", "-u", tmpDir)
err = cmd.Run()
return err

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not consider that, you're likely right.

Just one doubt: what happens if shred fails? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irrespective of shred exist or not ! the rule is triggering in this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here mkfs utility is not there in my system. Also the rule is triggering irrespective of utility existence

abcd

if err != nil {
return err
}

filename := filepath.Join(tmpDir, "file.txt")
if err := os.WriteFile(filename, []byte("bulk data content"), os.FileMode(0755)); err != nil {
return err
}

// Generating the event
const command = "shred"
h.Log().Infof("attempting to run %s command to remove bulk data from disk", command)
cmd := exec.Command("shred", "-u", tmpDir)
GLVSKiriti marked this conversation as resolved.
Show resolved Hide resolved
err = cmd.Run()
return err
}
Loading