Added event for default rule "Read SSH Information" #112
Conversation
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
|
It is also working as expected! Error log is produced on left terminal as expected
|
Signed-off-by: GLVS Kiriti <[email protected]>
…logic Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
|
@FedeDP Kindly tell me if there are any changes! |
| if err != nil { | ||
| return err | ||
| } | ||
| sshDir := filepath.Join(tempDirectoryName, ".ssh") |
There was a problem hiding this comment.
We don't need this line right? Since createSshDirectoryUnderHome already creates .ssh folder inside the temp folder it can just return sshDir!
There was a problem hiding this comment.
@FedeDP Yes we can do that! But before the function return we should also clean the temp folder created by createSshDirectoryUnderHome .
defer os.RemoveAll(tempDirectoryName)
So if we return sshDir instead of tempDir . How can we clean tempDir ?
There was a problem hiding this comment.
So if we return sshdir then one valid approach is trimming the last 5 characters in sshDir gives tempdir path. Is that ok?
There was a problem hiding this comment.
I got it, your are right! Nope, i'd leave another comment on the helper function!
events/syscall/utils_linux.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| return tempDirectoryName, nil |
There was a problem hiding this comment.
| return tempDirectoryName, nil | |
| return sshDir, nil |
There was a problem hiding this comment.
I got #112 (comment), what if this function also returns a cleanup function?, like:
return sshDir, func() { _ = os.RemoveAll(tempDirectoryName) }, nilthen the caller will just defer cleanup() after it captures the result, of course if cleanup != nil.
This is often used in go :)
There was a problem hiding this comment.
Yepp!! Awesome
Just did that and tested it its working absolutely fine 💯
Signed-off-by: GLVS Kiriti <[email protected]>
|
LGTM label has been added. Git tree hash: 9dbddf5a266c60ade1af9fcf089d373a940f9ed7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yess certainly It would be very useful |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Added event for default rule "Read SSH Information"
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: