adding an event on reading environment variable from /proc files #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4l0gen
changed the title
h4l0gen
changed the title
FedeDP
reviewed
Apr 9, 2024
|
|
||
| func ReadEnvironmentVariableFromProcFiles(h events.Helper) error { | ||
| if h.InContainer() { | ||
| cmd := exec.Command("cat", "/proc/*/environ") |
There was a problem hiding this comment.
Can we use just /proc/self/environ instead?
There was a problem hiding this comment.
Yes, @FedeDP, I have changed it, and the rule was triggered as well. After this change, the event generated less noise than the previous one :)
leogr
previously approved these changes
Apr 9, 2024
|
LGTM label has been added. Git tree hash: a0a4f8c832553bb2d20a8d6decb2ea61faf8ee49
|
Signed-off-by: h4l0gen <[email protected]> final Signed-off-by: h4l0gen <[email protected]>
leogr
approved these changes
Apr 23, 2024
|
LGTM label has been added. Git tree hash: 5d970b39ab615d28cb5b60d4fcb2aa1c90ff08a6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h4l0gen, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
this event trigger rule
read environment variable from /proc fileWhich issue(s) this PR fixes:
Fixes #111
Special notes for your reviewer: