adding an event on triggering rule disallowed ssh connection
#130
Conversation
| ) | ||
|
|
||
| func DisallowedSSHConnection(h events.Helper) error { | ||
| cmd := exec.Command("timeout", "1s", "ssh", "[email protected]", "-p", "22") |
There was a problem hiding this comment.
Yes @FedeDP, Let me modify it
There was a problem hiding this comment.
@FedeDP I made changes and rule triggering successfully and throwing error too when ssh is not present.
There was a problem hiding this comment.
Let's use example.com, if there's no alternative.
@FedeDP wdyt?
There was a problem hiding this comment.
@FedeDP If using example.com looks good to you, then we are good to go with this PR, please take a look.
Signed-off-by: h4l0gen <[email protected]> final Signed-off-by: h4l0gen <[email protected]>
|
/assign @FedeDP |
|
LGTM label has been added. Git tree hash: 0e27d3b86e3c0e1f9174f15818a7d3e486ff6e6c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, h4l0gen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
we need to detect functionality of rule
disallowed ssh connectionWhich issue(s) this PR fixes:
Fixes #129
Special notes for your reviewer: