Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Unprivileged Delegation of Page Faults Handling to a Userspace Process" #171

Conversation

GLVSKiriti
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule "Unprivileged Delegation of Page Faults Handling to a Userspace Process" as mentioned here

Which issue(s) this PR fixes:

Fixes #170

Special notes for your reviewer:

@GLVSKiriti
Copy link
Contributor Author

This event is also tested against a running a falco instance and produces the critical priority log as expected on left terminal

unprovilegedDelegationsofpagefaults

@GLVSKiriti
Copy link
Contributor Author

@FedeDP similarly this triggers irrespective of userfaultfd syscall is successful or not just an attempt is enough to trigger the rule so return nil;

// To make user.uid != 0
if err := becameUser(h, "daemon"); err != nil {
return err
}
// Attempt to create userfaultfd syscall is enough
unix.Syscall(unix.SYS_USERFAULTFD, 0, 0, 0)
return nil

@poiana poiana added the lgtm label Apr 3, 2024
@poiana
Copy link

poiana commented Apr 3, 2024

LGTM label has been added.

Git tree hash: ba7791d58984e180ddf7bc4b6a26b92443fbf5a4

@poiana
Copy link

poiana commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 3, 2024
@poiana poiana merged commit 786ea1c into falcosecurity:main Apr 3, 2024
3 of 4 checks passed
@GLVSKiriti GLVSKiriti deleted the UnprivilegedDelegationofPageFaultsHandlingtoaUserspaceProcess branch April 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an event for default rule "Unprivileged Delegation of Page Faults Handling to a Userspace Process"
3 participants