Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Container runner support for declarative yaml file testing method #216

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Jul 9, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Add support for container runner to execute tests inside a container which is also part of "add support for testing falco rules using declarative YAML files in event-generator". The implementation idea is here

Which issue(s) this PR fixes:
Part of GSoC 2024 project "Falco: Upgrading event-generator and automating Falco performance testing"
falcosecurity/evolution#362

Special notes for your reviewer:
cc @alacuku @jasondellaluce

Added setup and cleanup methods for container runner

Signed-off-by: GLVS Kiriti <[email protected]>
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Jul 16, 2024

LGTM label has been added.

Git tree hash: 2956b053a423ce241e0a151f7fe387f991c29044

@alacuku
Copy link
Member

alacuku commented Jul 18, 2024

/approve

@poiana
Copy link

poiana commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: alacuku, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 339f11a into falcosecurity:gsoc2024 Jul 18, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the containerRunnerSupport branch July 18, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants