Fix error handling AWS Security Lake with memlog usage

[embano1]

As the maintainer of memlog I am happy you are using my package! Actually found out incidentally while checking importers of the package. Went through the code and IMHO there are some minor corrections or clarifications needed for the error handling logic in:

falcosidekick/outputs/awssecuritylake.go

Lines 196 to 227 in 41d5308

	func (c *Client) EnqueueSecurityLake(falcopayload types.FalcoPayload) {
	offset, err := c.Config.AWS.SecurityLake.Memlog.Write(c.Config.AWS.SecurityLake.Ctx, []byte(falcopayload.String()))
	if err != nil {
	if err.Error() != "future offset" {
	go c.CountMetric(Outputs, 1, []string{"output:awssecuritylake.", "status:error"})
	c.Stats.AWSSecurityLake.Add(Error, 1)
	c.PromStats.Outputs.With(map[string]string{"destination": "awssecuritylake.", "status": Error}).Inc()
	log.Printf("[ERROR] : %v SecurityLake. - %v\n", c.OutputType, err)
	return
	}
	}
	log.Printf("[INFO] : %v SecurityLake. - Event queued (%v)\n", c.OutputType, falcopayload.UUID)
	*c.Config.AWS.SecurityLake.WriteOffset = offset
	}
	func (c *Client) StartSecurityLakeWorker() {
	for {
	time.Sleep(time.Duration(c.Config.AWS.SecurityLake.Interval) * time.Minute)
	// time.Sleep(5 * time.Second)
	batch := make([]memlog.Record, c.Config.AWS.SecurityLake.BatchSize)
	count, err := c.Config.AWS.SecurityLake.Memlog.ReadBatch(c.Config.AWS.SecurityLake.Ctx, *c.Config.AWS.SecurityLake.ReadOffset+1, batch)
	if err != nil {
	if err.Error() != "future offset" {
	go c.CountMetric(Outputs, 1, []string{"output:awssecuritylake.", "status:error"})
	c.Stats.AWSSecurityLake.Add(Error, 1)
	c.PromStats.Outputs.With(map[string]string{"destination": "awssecuritylake.", "status": Error}).Inc()
	log.Printf("[ERROR] : %v SecurityLake. - %v\n", c.OutputType, err)
	continue
	}
	}
	if count > 0 {
	var err error

For example, this line feels redundant as Write() never throws "future offset" - can be simplified: if err.Error() != "future offset"

Also, I recommend using errors.Is(err, memlog.Err<Type>) instead of string assertions.

if count > 0 ignores error cases where count == 0.

I am happy to provide a PR, just wanted to better understand the error handling code from the author @Issif

[Issif]

Thanks for your comments. I'll be happy to review a PR from you to fix my silly mistakes 👍