Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial contributing document #123

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 23, 2020

What type of PR is this?
/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:
Add initial CONTRIBUTING.md document

Which issue(s) this PR fixes:

Fixes #96

Special notes for your reviewer:

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for starting with this file, we need to discuss with whole community about how we deal with contributor files

@poiana
Copy link

poiana commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 23, 2020

LGTM label has been added.

Git tree hash: 14d3201e98467dc638ef5960c6ba21485cf40e33

@poiana poiana merged commit 4b4346b into falcosecurity:master Nov 23, 2020
@cpanato cpanato deleted the initial-contribuiting branch November 24, 2020 06:13
@cpanato
Copy link
Member Author

cpanato commented Nov 24, 2020

@Issif how about have a topic in the falco community meeting?

@Issif
Copy link
Member

Issif commented Nov 24, 2020

@cpanato I agree, that was my first idea and we already talked about with @leogr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CONTRIBUTING.md
3 participants