Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outputformat when using fields or text #204

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 8, 2021

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

fix small issue when using outputformat as fields or text

Which issue(s) this PR fixes:

Fixes #203

Special notes for your reviewer:

@poiana
Copy link

poiana commented Mar 8, 2021

@cpanato: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/S label Mar 8, 2021
@cpanato cpanato changed the title Gh 203 Fix outputformat when using fields or text Mar 8, 2021
@poiana poiana added the lgtm label Mar 8, 2021
@poiana
Copy link

poiana commented Mar 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 8, 2021

LGTM label has been added.

Git tree hash: ad55f0a1fbd5d08c570d055af20242f0f8631c88

@poiana poiana added the approved label Mar 8, 2021
@Issif Issif added this to the 2.22.0 milestone Mar 8, 2021
@poiana poiana merged commit 41cc715 into falcosecurity:master Mar 8, 2021
@cpanato cpanato deleted the GH-203 branch March 8, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Slack Output w/ SLACK_OUTPUTFORMAT of "fields" same as "all"
3 participants