Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS IRSA support #238

Merged
merged 1 commit into from
May 18, 2021
Merged

AWS IRSA support #238

merged 1 commit into from
May 18, 2021

Conversation

dchoy
Copy link
Contributor

@dchoy dchoy commented May 4, 2021

Use previously created session to avoid using deprecated session.New()
Use session.NewSession() to allow AWS IRSA

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #219

Special notes for your reviewer:

@poiana
Copy link

poiana commented May 4, 2021

Welcome @dchoy! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label May 4, 2021
Use previously created session to avoid using deprecated session.New()
Use session.NewSession() to allow AWS IRSA

Signed-off-by: David Choy <>
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you

@poiana poiana added the lgtm label May 5, 2021
@poiana
Copy link

poiana commented May 5, 2021

LGTM label has been added.

Git tree hash: a3340462fa9cb2e426ac719ca1d97034ffaa32b1

@poiana poiana added the approved label May 5, 2021
@Issif Issif added this to the 2.23.0 milestone May 5, 2021
@Issif Issif changed the title AWS IRSA support WIP: AWS IRSA support May 9, 2021
@Issif Issif modified the milestones: 2.23.0, 2.24.0 May 16, 2021
@Issif Issif changed the title WIP: AWS IRSA support AWS IRSA support May 16, 2021
@Issif Issif modified the milestones: 2.24.0, 2.23.0 May 16, 2021
@Issif Issif removed the approved label May 17, 2021
@leogr
Copy link
Member

leogr commented May 18, 2021

Closing and reopening to trigger the CI
/close

@poiana poiana closed this May 18, 2021
@poiana
Copy link

poiana commented May 18, 2021

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented May 18, 2021

/open

@leogr leogr reopened this May 18, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 166fe18 into falcosecurity:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AWS Output's don't work with IAM Role Service Accounts.
5 participants