-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Google Cloud Run output type #243
add Google Cloud Run output type #243
Conversation
/kind feature |
27f3f71
to
7d914a3
Compare
7d914a3
to
c3e72c9
Compare
c3e72c9
to
67e64f6
Compare
outputs/client.go
Outdated
@@ -178,6 +178,12 @@ func (c *Client) Post(payload interface{}) error { | |||
req.Header.Add("event-namespace", c.Config.Kubeless.Namespace) | |||
} | |||
|
|||
if c.OutputType == "GCPCloudRun" { | |||
if c.Config.GCP.CloudRun.JWT != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made that control for users who might want to use the workload identity feature instead of JWT based authentication. So, JWT based authentication should not be required for us, but if the users want JWT based authentication to enable, we should add it to the Authorization header.
outputs/client.go
Outdated
if c.OutputType == "GCPCloudRun" { | ||
if c.Config.GCP.CloudRun.JWT != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if c.OutputType == "GCPCloudRun" { | |
if c.Config.GCP.CloudRun.JWT != "" { | |
if c.OutputType == "GCPCloudRun" && c.Config.GCP.CloudRun.JWT != "" { |
Nested if
is useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are missing the updates of:
- README.md
- stats.go
- config_example.yaml
67e64f6
to
462f973
Compare
@cartyc friend, would you mind to look at this issue, I couldn't get it to work with "Workload Identity", seems it's not working without providing a valid JWT. 🤔 |
462f973
to
0a98f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update of env var in README too please 😉
0a98f6d
to
1448f3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add it in the list of outputs
LGTM label has been added. Git tree hash: dfdf490cd1ff7079c942859dac707428b5f9069e
|
1448f3c
to
64529d9
Compare
fcf744f
to
c3c7d47
Compare
c3c7d47
to
5079b63
Compare
Signed-off-by: Batuhan Apaydın <[email protected]>
5079b63
to
ea94ae0
Compare
LGTM label has been added. Git tree hash: d6c3407e6273e9e46db5bd71e651801b95ec6bc9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Batuhan Apaydın [email protected]
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR enables to use of Google Cloud Run as an output.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: