Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KafkaRest as new output for Falco Sidekick #263

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Aug 5, 2021

Signed-off-by: Engin Diri [email protected]

What type of PR is this?

Fixes #262

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
The Kafka REST Proxy provides a RESTful interface to a Apache Kafka cluster, making it easy to produce and consume messages, view the state of the cluster, and perform administrative actions without using the native Kafka protocol or clients.

Which issue(s) this PR fixes: #262

Fixes #262

Special notes for your reviewer:

@poiana
Copy link

poiana commented Aug 5, 2021

Welcome @dirien! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@Issif
Copy link
Member

Issif commented Aug 5, 2021

Thank you very much, this is a very valuable PR, with a really nice description. I'll review asap but a first look tells me it's already really good.

👍

config.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
outputs/kafkarest.go Outdated Show resolved Hide resolved
@dirien
Copy link
Contributor Author

dirien commented Aug 6, 2021

@Issif, Thanks for the feedback. I changed everything according to your suggestions. looking forward. 😄

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 thing is missing, can you add your output in this list please

@dirien
Copy link
Contributor Author

dirien commented Aug 6, 2021

@Issif, done :) during the Yandex rebase it must slipped through 😓

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats and thank you !!

@poiana poiana added the lgtm label Aug 6, 2021
@poiana
Copy link

poiana commented Aug 6, 2021

LGTM label has been added.

Git tree hash: c9f7536a6b043e7ccb6bc9a8b98d10a4f984ab63

@poiana
Copy link

poiana commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dirien, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 6, 2021
@Issif Issif closed this Aug 11, 2021
@Issif Issif reopened this Aug 11, 2021
@poiana poiana merged commit 2fdbf2e into falcosecurity:master Aug 11, 2021
@dirien dirien deleted the kafkarest branch August 12, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support Kafka Rest Output
3 participants