Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set header x-amz-acl to bucket-owner-full-control #264

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Aug 11, 2021

Signed-off-by: Kaizhe Huang [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

For scenarios that falcosidekick does not own the s3 bucket, we should allow to grant the object privileges to bucket owner. By default, the bucket owner do not have access on the objects created by falcosidekick from different aws accounts. For more details: https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html

Which issue(s) this PR fixes:

N/A

Fixes #

Special notes for your reviewer:

@Kaizhe
Copy link
Contributor Author

Kaizhe commented Aug 11, 2021

/kind feature

@poiana poiana added kind/feature New feature or request and removed needs-kind labels Aug 11, 2021
@Kaizhe
Copy link
Contributor Author

Kaizhe commented Aug 11, 2021

/area outputs

@developer-guy
Copy link
Contributor

LGTM @Kaizhe ! 👏

@developer-guy
Copy link
Contributor

/approve

@developer-guy
Copy link
Contributor

PTAL @Issif

@poiana
Copy link

poiana commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: developer-guy, Issif, Kaizhe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Issif,developer-guy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Aug 11, 2021

LGTM label has been added.

Git tree hash: 3c3eec19c9e35d607a9c756edea3d0632efa7f30

@Issif Issif added this to the 2.24.0 milestone Aug 11, 2021
@poiana poiana merged commit 5213221 into falcosecurity:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants