Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoho Cliq output #301

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Zoho Cliq output #301

merged 2 commits into from
Jan 9, 2022

Conversation

averni
Copy link
Contributor

@averni averni commented Jan 8, 2022

Signed-off-by: Antonio Verni [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

This PR allows post events to Zoho Cliq

Special notes for your reviewer:

Zoho Cliq API reference: https://www.zoho.com/cliq/help/restapi/v2/

Signed-off-by: Antonio Verni <[email protected]>
@poiana
Copy link

poiana commented Jan 8, 2022

Welcome @averni! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XL label Jan 8, 2022
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good PR, thank you 👍

README.md Outdated
Comment on lines 725 to 739
- **CLIQ_WEBHOOKURL** : Zoho Cliq Channel URL (ex:
https://cliq.zoho.eu/api/v2/channelsbyname/XXXX/message?zapikey=YYYY), if not `empty`, Cliq
Chat output is _enabled_
- **CLIQ_ICON** : Cliq icon (avatar)
- **CLIQ_USEEMOJI** : Prefix message text with an emoji
- **CLIQ_OUTPUTFORMAT** : `all` (default), `text` (only text is displayed in
Cliq), `fields` (only fields are displayed in Cliq)
- **CLIQ_MINIMUMPRIORITY** : minimum priority of event for using this
output, order is
`emergency|alert|critical|error|warning|notice|informational|debug or "" (default)`
- **CLIQ_MESSAGEFORMAT** : a Go template to format Google Chat Text above
Attachment, displayed in addition to the output from
`CLIQ_OUTPUTFORMAT`, see
[Slack Message Formatting](#slack-message-formatting) in the README for
details. If empty, no Text is displayed before sections.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **CLIQ_WEBHOOKURL** : Zoho Cliq Channel URL (ex:
https://cliq.zoho.eu/api/v2/channelsbyname/XXXX/message?zapikey=YYYY), if not `empty`, Cliq
Chat output is _enabled_
- **CLIQ_ICON** : Cliq icon (avatar)
- **CLIQ_USEEMOJI** : Prefix message text with an emoji
- **CLIQ_OUTPUTFORMAT** : `all` (default), `text` (only text is displayed in
Cliq), `fields` (only fields are displayed in Cliq)
- **CLIQ_MINIMUMPRIORITY** : minimum priority of event for using this
output, order is
`emergency|alert|critical|error|warning|notice|informational|debug or "" (default)`
- **CLIQ_MESSAGEFORMAT** : a Go template to format Google Chat Text above
Attachment, displayed in addition to the output from
`CLIQ_OUTPUTFORMAT`, see
[Slack Message Formatting](#slack-message-formatting) in the README for
details. If empty, no Text is displayed before sections.
- **CLIQ_WEBHOOKURL**: Zoho Cliq Channel URL (ex:
https://cliq.zoho.eu/api/v2/channelsbyname/XXXX/message?zapikey=YYYY), if not `empty`, Cliq
Chat output is _enabled_
- **CLIQ_ICON**: Cliq icon (avatar)
- **CLIQ_USEEMOJI**: Prefix message text with an emoji
- **CLIQ_OUTPUTFORMAT**: `all` (default), `text` (only text is displayed in
Cliq), `fields` (only fields are displayed in Cliq)
- **CLIQ_MINIMUMPRIORITY**: minimum priority of event for using this
output, order is
`emergency|alert|critical|error|warning|notice|informational|debug or "" (default)`
- **CLIQ_MESSAGEFORMAT**: a Go template to format Google Chat Text above
Attachment, displayed in addition to the output from
`CLIQ_OUTPUTFORMAT`, see
[Slack Message Formatting](#slack-message-formatting) in the README for
details. If empty, no Text is displayed before sections.

Signed-off-by: Antonio Verni <[email protected]>
@averni averni requested a review from Issif January 9, 2022 20:28
@poiana poiana added the lgtm label Jan 9, 2022
@poiana
Copy link

poiana commented Jan 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: averni, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 9, 2022

LGTM label has been added.

Git tree hash: 0984912c377d46d05f03026f4a1b24e57612d8d1

@poiana poiana added the approved label Jan 9, 2022
@poiana poiana merged commit 9275aa9 into falcosecurity:master Jan 9, 2022
@Issif Issif added this to the 2.25.0 milestone Jan 9, 2022
@averni averni deleted the feature/output-cliq branch January 9, 2022 22:07
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants