fix Panic for prometheus metrics when CustomFields are set #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
Issif
force-pushed
the
fix-customfields-labels
branch
from
e9cefe9
to
dc66867
Compare
… labels for Loki for CustomFields and ExtraFields Signed-off-by: Issif <[email protected]>
Issif
force-pushed
the
fix-customfields-labels
branch
from
dc66867
to
c245802
Compare
fjogeleit
approved these changes
Jun 17, 2022
|
LGTM label has been added. Git tree hash: 6d0fe4107a897c6a9fb7184e2b3348bcab29ac28
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjogeleit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… labels for Loki for CustomFields and ExtraFields
Signed-off-by: Issif [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
#330
/area config
/area outputs
What this PR does / why we need it:
Fix the Panic for Prometheus when custom_fields are set
Allow to specify which fields to use as extra labels for Prometheus and Loki
Some lints
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: