Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back priority label for Alertmanager outputs #340

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

tks98
Copy link
Contributor

@tks98 tks98 commented Jun 29, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR adds back the priority label for alertmanager outputs. Release 2.25.0 was supposed to resolve #276 and add it but priority was replaced with eventsource.

Fixes #339

Special notes for your reviewer:

@poiana poiana added kind/bug Something isn't working dco-signoff: no kind/feature New feature or request area/outputs area/tests labels Jun 29, 2022
@poiana
Copy link

poiana commented Jun 29, 2022

Welcome @tks98! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@Issif
Copy link
Member

Issif commented Jun 29, 2022

I let you sign off your commit and I'll approve.

git commit -s --amend && git push origin master -f

@tks98
Copy link
Contributor Author

tks98 commented Jun 29, 2022

I let you sign off your commit and I'll approve.

git commit -s --amend && git push origin master -f

Had to sign off my first commit also since there were two. Please let me know if anything else is required. Thanks!

@Issif Issif closed this Jun 29, 2022
@Issif Issif reopened this Jun 29, 2022
@poiana
Copy link

poiana commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, tks98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jun 30, 2022

LGTM label has been added.

Git tree hash: 5a241a3fe09ce935bab8bb19ff95412464ed52e5

@poiana poiana merged commit 70eba01 into falcosecurity:master Jun 30, 2022
@Issif Issif added this to the 2.27.0 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Alertmanager output priority label was replaced with event source
3 participants