-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format string for Slack outputs #40
Conversation
This is a really interesting idea, that could be reproduced for other outputs ( For Slack, I choosed to avoid the We must also provide more intels about available For example in :
If You edited |
I opted to put this in the message Text so it would be easy to pick out - the hope is that surfacing a subset of information makes alerts clearer for the people triaging them? I think putting it in the attachment Text could also work but it loses some differentiation from the body of the message - in a busy channel it gets hard to pick out the individual events. Plus this way it didn't conflict with any existing features, in case people want this and the output value. But I'm open to changing it if you have strong feelings about it.
There's three failure modes:
I'll write some more explicit documentation and clean this up. |
You convinced me. Ok for your idea. I proposed some suggestions while reviewing. I'll test your branch next Monday and merge for 2.9.1 if ok. |
Sounds good, thanks for the quick review! |
2b30109
to
9793d55
Compare
9793d55
to
4e78bd6
Compare
Co-Authored-By: Thomas Labarussias <[email protected]>
I released 2.9.1 with your PR. Thanks. |
Add a new configuration option for the Slack output, which allows users to customize the text of the Slack message in addition to the existing attachments. The current
all
andtext
options are verbose and make it hard to surface specific valuable information. Using Go templates also gives users some flexibility to do some basic string munging.