Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove brackets in labels + add Number as DataType #419

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Issif
Copy link
Member

@Issif Issif commented Mar 20, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Remove the brackets in MessageAtrributes keys for AWS SNS output to fix:

2023/03/18 21:18:01 [ERROR] : AWS SNS - ParameterValueInvalid: Invalid non-alphanumeric character '#x5B' was found in the message attribute name. Can only include alphanumeric characters, hyphens, underscores, or dots.

Add new DataType for MessageAtrributes keys for AWS SNS output:

        "proc.pid": {
            "BinaryValue": null,
            "DataType": "Number",
            "StringValue": "3009605"
        },

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added dco-signoff: yes kind/bug Something isn't working labels Mar 20, 2023
@poiana poiana requested a review from cpanato March 20, 2023 10:53
@poiana poiana added the kind/feature New feature or request label Mar 20, 2023
@poiana poiana requested a review from leogr March 20, 2023 10:53
@Issif Issif added this to the 2.28.0 milestone Mar 20, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Mar 20, 2023

LGTM label has been added.

Git tree hash: 865d8057b9e5ee9fa1d8066f9ab314a2307503c4

@poiana
Copy link

poiana commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3524e70 into master Mar 20, 2023
@poiana poiana deleted the aws-sns-fix-bracket branch March 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants