feat(severity-priority): match the priority with alertmanager severity label #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I was successively sick, off and at kubecon in last weeks. I'll review your PR this week. Thanks |
|
No problem mate ! |
|
It seems OK to me, can you update the README + the config_example.yaml please |
Issif
reviewed
Apr 27, 2023
Issif
requested changes
Apr 27, 2023
Lowaiz
force-pushed
the
feat/severity-priority
branch
from
5b1c84c
to
efce2eb
Compare
Issif
requested changes
Apr 27, 2023
Lowaiz
force-pushed
the
feat/severity-priority
branch
2 times, most recently
from
18e860b
to
f2abae5
Compare
|
Hey @Issif |
Issif
requested changes
May 22, 2023
Lowaiz
force-pushed
the
feat/severity-priority
branch
from
c008d19
to
3e21fcc
Compare
Issif
previously approved these changes
Jun 26, 2023
|
LGTM label has been added. Git tree hash: cc871c7af2a36f928aff45ae54ddeafc10a51574
|
|
Can you rebase to fix the conflict in the |
…y label Signed-off-by: Lyonel Martinez <[email protected]>
Signed-off-by: Lyonel Martinez <[email protected]>
Signed-off-by: Lyonel Martinez <[email protected]>
Lowaiz
force-pushed
the
feat/severity-priority
branch
from
3e21fcc
to
f07dc7c
Compare
|
@Issif Rebases done |
Issif
approved these changes
Jul 6, 2023
|
LGTM label has been added. Git tree hash: b9c780ad44daf713780eae83174127f5d9b8eeff
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Lowaiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it:
Automatch the priority of a falco alert into a severity label.
There is a configuration options built to over the default map if the priority is found in this config map. Otherwise, we use the default.
The configuration checks if the indicated priority is a valid one.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I'll update the docs once the feature is validated and fully dev.