Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alertmanager: validate labels and annotation names only, not values #441

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix: alertmanager: validate labels and annotation names only, not values #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 19 additions & 27 deletions config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,41 +496,33 @@ func getConfig() *types.Configuration {
}
}
}
regex, _ := regexp.Compile("^[a-zA-Z_:][a-zA-Z0-9_:]*$")

promKVNameRegex, _ := regexp.Compile("^[a-zA-Z_][a-zA-Z0-9_]*$")

if value, present := os.LookupEnv("ALERTMANAGER_EXTRALABELS"); present {
extralabels := strings.Split(value, ",")
for _, labelData := range extralabels {
if !regex.MatchString(labelData) {
log.Printf("[ERROR] : AlertManager - Extra field '%v' is not a valid prometheus labelData", labelData)
continue
}
values := strings.SplitN(labelData, ":", 2)
label := strings.TrimSpace(values[0])
if !regex.MatchString(label) {
log.Printf("[ERROR] : AlertManager - Extra field '%v' is not a valid prometheus label", label)
continue
}
if len(values) == 2 {
c.Alertmanager.ExtraLabels[label] = strings.TrimSpace(values[1])
extraLabels := strings.Split(value, ",")
for _, labelData := range extraLabels {
labelName, labelValue, found := strings.Cut(labelData, ":")
if !promKVNameRegex.MatchString(labelName) {
log.Printf("[ERROR] : AlertManager - Extra label name '%v' is not valid", labelName)
} else if found {
c.Alertmanager.ExtraLabels[labelName] = strings.TrimSpace(labelValue)
} else {
c.Alertmanager.ExtraLabels[label] = ""
c.Alertmanager.ExtraLabels[labelName] = ""
}
}
}

if value, present := os.LookupEnv("ALERTMANAGER_EXTRAANNOTATIONS"); present {
extraannotations := strings.Split(value, ",")
for _, annotationData := range extraannotations {
values := strings.SplitN(annotationData, ":", 2)
annotation := strings.TrimSpace(values[0])
if !regex.MatchString(annotation) {
log.Printf("[ERROR] : AlertManager - Extra field '%v' is not a valid prometheus annotation", annotation)
continue
}
if len(values) == 2 {
c.Alertmanager.ExtraAnnotations[annotation] = strings.TrimSpace(values[1])
extraAnnotations := strings.Split(value, ",")
for _, annotationData := range extraAnnotations {
annotationName, annotationValue, found := strings.Cut(annotationData, ":")
if !promKVNameRegex.MatchString(annotationName) {
log.Printf("[ERROR] : AlertManager - Extra annotation name '%v' is not valid", annotationName)
} else if found {
c.Alertmanager.ExtraAnnotations[annotationName] = strings.TrimSpace(annotationValue)
} else {
c.Alertmanager.ExtraAnnotations[annotation] = ""
c.Alertmanager.ExtraAnnotations[annotationName] = ""
}
}
}
Expand Down