Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SMTP AuthMechanism to disable SASL Auth #503

Closed
wants to merge 1 commit into from

Conversation

apsega
Copy link
Contributor

@apsega apsega commented Jun 8, 2023

When I want to disable SASL Auth, I'm setting environment variable of SMTP_AUTHMECHANISM, to "", but it doesn't work and defaults to plain, logs:

2023/06/08 09:50:06 [DEBUG] : SMTP - SASL Auth :
Mechanisms: plain
User:
Token:
Identity:
Trace:

/kind bug
/area outputs

@poiana poiana added dco-signoff: no kind/bug Something isn't working labels Jun 8, 2023
@poiana
Copy link

poiana commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apsega
Once this PR has been reviewed and has the lgtm label, please assign fjogeleit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jun 8, 2023

Welcome @apsega! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/S label Jun 8, 2023
@Issif
Copy link
Member

Issif commented Jun 8, 2023

Hi,

Thank you for your PR, I already created a PR recently to change how the output send the emails, it allows to disable the auth by letting the setting empty.

#502

edit: I changed my PR to follow yours, no the value to disable is "none"

@apsega
Copy link
Contributor Author

apsega commented Jun 8, 2023

@Issif thanks! I'll close the PR then. Looking forward to cut the release.

@apsega apsega closed this Jun 8, 2023
@apsega apsega deleted the fix/smtp_noauth branch June 8, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants