Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple kafka bootstrap servers #571

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

ibice
Copy link
Contributor

@ibice ibice commented Jul 25, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

  • Support multiple Kafka bootstrap servers the same way other producers do. This way we can fetch initial cluster metadata from a different server in case one of them is down.
  • Update the documentation to explicitly state that the kafka hostport property refers to bootstrap nodes and not just to brokers.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Jul 25, 2023

Welcome @ibice! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from fjogeleit and Issif July 25, 2023 12:28
@poiana poiana added the size/XS label Jul 25, 2023
@Issif Issif added this to the 2.28.0 milestone Jul 25, 2023
@poiana
Copy link

poiana commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibice, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jul 25, 2023

LGTM label has been added.

Git tree hash: 2eec98653a20b80b537d7e6a20badeb16d97af0d

@Issif
Copy link
Member

Issif commented Jul 25, 2023

Good to me, thanks

@poiana poiana merged commit 4d11678 into falcosecurity:master Jul 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants