Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynatrace output #575

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Add Dynatrace output #575

merged 5 commits into from
Aug 2, 2023

Conversation

blu3r4y
Copy link
Contributor

@blu3r4y blu3r4y commented Jul 31, 2023

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

Adds Dynatrace output to falcosidekick.

@poiana
Copy link

poiana commented Jul 31, 2023

Welcome @blu3r4y! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from cpanato and Issif July 31, 2023 10:29
@poiana poiana added the size/L label Jul 31, 2023
@Issif
Copy link
Member

Issif commented Jul 31, 2023

Hi,

Thanks a lot for your contribution. I'm in PTO this week, I will review this later when I'm back. FYI, I released a new version few days ago, I don't know when the next one will be out. Do you need this integration asap?

@blu3r4y
Copy link
Contributor Author

blu3r4y commented Jul 31, 2023

Hi @Issif, thanks for your quick response. We would like to announce this in a blog post within the next two weeks. Having a (pre-)release within the next couple of weeks would be awesome!! No hurry for now, enjoy your PTO, see you next week :)

@Issif
Copy link
Member

Issif commented Aug 1, 2023

@blu3r4y I'll do my best to have a 2.29.0-rc1 next week. This is a great news, if you need anything for your blog post, tell me, that's my job to help you. If you agree, you could also propose a post for falco.org or even better, participate in our use-case section.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config_example.yaml Outdated Show resolved Hide resolved
outputs/dynatrace.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
config_example.yaml Show resolved Hide resolved
@blu3r4y
Copy link
Contributor Author

blu3r4y commented Aug 1, 2023

@blu3r4y I'll do my best to have a 2.29.0-rc1 next week. This is a great news, if you need anything for your blog post, tell me, that's my job to help you. If you agree, you could also propose a post for falco.org or even better, participate in our use-case section.

@Issif Awesome, thanks! Also, we do plan additional content in that direction. I will make sure to reach out when we get there.

One specific question: We would love to use the Falco logo in the header for our blog post. As long as we comply with the CNCF brand guidelines this should be fine, right?

@Issif
Copy link
Member

Issif commented Aug 2, 2023

Thank you.

For the logo, feel free to use it as you want, you can find the assets here: https://falco.org/community/falco-brand/

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Aug 2, 2023
@poiana
Copy link

poiana commented Aug 2, 2023

LGTM label has been added.

Git tree hash: 79725718940b332bb2e4c6e6f6948022100c8a5f

@poiana
Copy link

poiana commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blu3r4y, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 2, 2023
@poiana poiana merged commit 5c4e6cf into falcosecurity:master Aug 2, 2023
5 checks passed
@Issif Issif added this to the 2.29.0 milestone Aug 2, 2023
@Issif
Copy link
Member

Issif commented Aug 2, 2023

@blu3r4y
Copy link
Contributor Author

blu3r4y commented Aug 2, 2023

@Issif This is awesome, thanks so much for your swift assistance! 🥳

@blu3r4y blu3r4y deleted the dynatrace-output branch September 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants