fix(loki): fix the deadlock in Loki integration

[bsod90]

I believe this should be the fix for #646, but I'm still figuring out a way to test it locally.

[poiana]

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[poiana]

Welcome @bsod90! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

[Issif]

As you confirmed it works, I'm approving.

FYI, I would have used anonymous functions.

Something like:

func (c *Client) LokiPost(falcopayload types.FalcoPayload) {
	c.Stats.Loki.Add(Total, 1)
	c.ContentType = LokiContentType

	if c.Config.Loki.User != "" && c.Config.Loki.APIKey != "" {
		func() {
				c.httpClientLock.Lock()
				defer c.httpClientLock.Unlock()
				c.BasicAuth(c.Config.Loki.User, c.Config.Loki.APIKey)
		}()
	}

[poiana]

LGTM label has been added.

Git tree hash: cc3d9117460b639b38ae42541b004e150ee09662

[Issif]

can you sign-off your commit please

[bsod90]

Thank you so much, @Issif !
Just added the sign-off
Also, didn't know about anonymous functions, Go isn't my first language :) Thanks!

[Issif]

All good, for the anonymous functions I thought it was interesting for you to mention them 😉

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsod90, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bsod90]

A quick follow-up question: when do you expect the next minor release to be cut? I'm asking because I'm trying to use Loki integration in our infra and it would be easier to just use the official image instead of forking, custom-building, etc.
Thanks! @Issif

[Issif]

@bsod90 I created an RC for you https://github.com/falcosecurity/falcosidekick/releases/tag/2.29.0-rc.3

[bsod90]

Thank you!

…

On Thu, Sep 28, 2023 at 5:46 AM Thomas Labarussias ***@***.***> wrote: @bsod90 <https://github.com/bsod90> I created an RC for you https://github.com/falcosecurity/falcosidekick/releases/tag/2.29.0-rc.3 — Reply to this email directly, view it on GitHub <#647 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARPWEY26GU45NAEBK6QAMLX4VWSBANCNFSM6AAAAAA5GUH3RM> . You are receiving this because you were mentioned.Message ID: ***@***.***>