Adding Azure EventHubs as output #66
Conversation
|
/kind feature |
|
Thanks for that great MR. I'm doing a review ASAP, even if I don't know how Azure works 😉 |
|
@arminc We've integrated an automatic system, poiana for handling merge requests and be consistent with the whole falcosecurity organization. It implies you sign-off all your commits, can you do that pleaseN |
Signed-off-by: Armin <[email protected]>
|
Done |
|
@arminc That's great. Can you add more details in README for telling this output only works if |
Signed-off-by: Armin <[email protected]>
Signed-off-by: Armin <[email protected]>
Signed-off-by: Armin <[email protected]>
Signed-off-by: Armin <[email protected]>
|
|
||
| azure: | ||
| # eventHub: | ||
| # name: "" # The name of the Hub, EventHub output is enabled |
There was a problem hiding this comment.
| # name: "" # The name of the Hub, EventHub output is enabled | |
| # name: "" # The name of the Hub, if not empty, EventHub output is enabled |
| @@ -271,6 +279,9 @@ The *env vars* "match" field names in *yaml file with this structure (**take car | |||
| * **DOGSTATSD_TAGS**: A comma-separated list of tags to add to all metrics | |||
| * **WEBHOOK_ADDRESS** : "" # Webhook address, if not empty, Webhook output is enabled | |||
| * **WEBHOOK_MINIMUMPRIORITY** : minimum priority of event for using this output, order is `emergency|alert|critical|error|warning|notice|informational|debug or "" (default)` | |||
| * **AZURE_EVENTHUB_NAME**: Name of the Hub, EventHub is *enabled* | |||
There was a problem hiding this comment.
| * **AZURE_EVENTHUB_NAME**: Name of the Hub, EventHub is *enabled* | |
| * **AZURE_EVENTHUB_NAME**: Name of the Hub, if not empty, EventHub is *enabled* |
|
LGTM label has been added. Git tree hash: d3b5818ea2f9f8be9b7348f0ef13935d95ea25a4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@arminc As my last comments are simple, I approved because feature seems working for me. |
This adds Azure EventHubs as an output option. The current implementation assumes usage of Azure "aad-pod-identity".
Extra: It adds priorityClassName to the helm chart.