check cert validity #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
force-pushed
the
disable-cert-check
branch
from
9f0bb95
to
d6b8d8f
Compare
Signed-off-by: Issif <[email protected]>
Issif
force-pushed
the
disable-cert-check
branch
from
d6b8d8f
to
0227271
Compare
airadier
suggested changes
Aug 5, 2020
Signed-off-by: Issif <[email protected]>
airadier
previously approved these changes
Aug 6, 2020
|
LGTM label has been added. Git tree hash: 0315971d4e086432ad2efdab649f07666712ef7d
|
Signed-off-by: Issif <[email protected]>
Issif
force-pushed
the
disable-cert-check
branch
from
6134dab
to
7f485dd
Compare
leodido
approved these changes
Aug 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it:
Some outputs can be managed and have auto-signed SSL certificate, without the correct CA the POST fail.
Which issue(s) this PR fixes:
#70
Fixes #