-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syslog.md #748
Update syslog.md #748
Conversation
Signed-off-by: cccsss01 <[email protected]>
Signed-off-by: cccsss01 <[email protected]>
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR
can your give some context why we need to add this? and maybe add in documentation as well, it is not clear why need that
Co-authored-by: Carlos Tadeu Panato Junior <[email protected]> Signed-off-by: cccsss01 <[email protected]>
I have another version that isn't working with this so there is likely some requirement, and since there isn't any information on what this was tested on, I've confirmed it works with this version specified. Happy to change words to, anything like last known working version or what not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not clear why we need that but also does not break or impact anything
/approve
/lgtm
LGTM label has been added. Git tree hash: 5c6cf5bd9b52cc25faaba653514192cfc4c442aa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cccsss01, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you |
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: