Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syslog.md #748

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Update syslog.md #748

merged 3 commits into from
Jan 17, 2024

Conversation

cccsss01
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: cccsss01 <[email protected]>
Signed-off-by: cccsss01 <[email protected]>
@cccsss01
Copy link
Contributor Author

/kind documentation

docs/outputs/syslog.md Outdated Show resolved Hide resolved
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR

can your give some context why we need to add this? and maybe add in documentation as well, it is not clear why need that

Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
Signed-off-by: cccsss01 <[email protected]>
@cccsss01
Copy link
Contributor Author

thanks for this PR

can your give some context why we need to add this? and maybe add in documentation as well, it is not clear why need that

I have another version that isn't working with this so there is likely some requirement, and since there isn't any information on what this was tested on, I've confirmed it works with this version specified.

Happy to change words to, anything like last known working version or what not

@Issif Issif requested a review from cpanato January 15, 2024 13:17
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not clear why we need that but also does not break or impact anything

/approve
/lgtm

@poiana poiana added the lgtm label Jan 17, 2024
@poiana
Copy link

poiana commented Jan 17, 2024

LGTM label has been added.

Git tree hash: 5c6cf5bd9b52cc25faaba653514192cfc4c442aa

@poiana
Copy link

poiana commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cccsss01, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Jan 17, 2024

thank you

@poiana poiana merged commit dc4d2b7 into falcosecurity:master Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants