fix, unsupported strings in alertmanager keys #78
Conversation
|
@epcim: There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @epcim! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
what is contrib policy, how to sign-off ? Details link fails.. (will fix over weekend ) |
outputs/alertmanager.go
Outdated
| //AlertManger doesn't support dots in a label name | ||
| amPayload.Labels[strings.Replace(i, ".", "_", -1)] = j.(string) | ||
| //AlertManger unsupported chars in a label name | ||
| replacer := strings.NewReplacer(".", "_", "[", "", "]", "") |
There was a problem hiding this comment.
| replacer := strings.NewReplacer(".", "_", "[", "", "]", "") | |
| replacer := strings.NewReplacer(".", "_", "[", "_", "]", "") |
I think it's better to replace proc_aname[2] by proc_aname_2, what do you think?
The easiest is : |
ref: falcosecurity#77 Signed-off-by: Petr Michalec <[email protected]>
|
LGTM label has been added. Git tree hash: 716b6e659a9b81db43eddc41a5d2f637eed9ff7c
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref: #77
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: