Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Install' section to systemd example in README #835

Merged

Conversation

marcomandola
Copy link

@marcomandola marcomandola commented Apr 5, 2024

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area config

What this PR does / why we need it:

This PR adds the [Install] section in the Systemd Installation example in README.
This is required for enabling and disabling services, as per RedHat Documentation.

When following the systemd installation example, sudo systemctl enable falcosidekick currently fails with the following error:

The unit files have no installation config (WantedBy=, RequiredBy=, Also=,
Alias= settings in the [Install] section, and DefaultInstance= for template
units). This means they are not meant to be enabled using systemctl.

Possible reasons for having this kind of units are:
• A unit may be statically enabled by being symlinked from another unit's
  .wants/ or .requires/ directory.
• A unit's purpose may be to act as a helper for some other unit which has
  a requirement dependency on it.
• A unit may be started when needed via activation (socket, path, timer,
  D-Bus, udev, scripted systemctl call, ...).
• In case of template units, the unit is meant to be enabled with some
  instance name specified.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@poiana
Copy link

poiana commented Apr 5, 2024

Welcome @marcomandola! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from cpanato and Issif April 5, 2024 08:09
@poiana poiana added the size/XS label Apr 5, 2024
@Issif Issif added this to the 2.29.0 milestone Apr 5, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@poiana poiana added the lgtm label Apr 5, 2024
@poiana
Copy link

poiana commented Apr 5, 2024

LGTM label has been added.

Git tree hash: 7503c81bd64330aebef5af0bd170905b5707ba8d

@poiana poiana added the approved label Apr 5, 2024
@poiana
Copy link

poiana commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, marcomandola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif Issif closed this Apr 5, 2024
@Issif Issif reopened this Apr 5, 2024
@poiana poiana merged commit fb73c63 into falcosecurity:master Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants