Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more checks for the upload on GCP Storage #858

Merged
merged 1 commit into from
Apr 27, 2024
Merged

add more checks for the upload on GCP Storage #858

merged 1 commit into from
Apr 27, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Apr 27, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Checks more the result of the upload to GCP Storage

Which issue(s) this PR fixes:

#809

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from cpanato and leogr April 27, 2024 15:04
@Issif Issif added this to the 2.29.0 milestone Apr 27, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Apr 27, 2024

LGTM label has been added.

Git tree hash: 187e128361e4fce8d75ce0150c1b7a71238dc49c

@poiana
Copy link

poiana commented Apr 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 67b4948 into master Apr 27, 2024
5 checks passed
@poiana poiana deleted the fix/809 branch April 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants