add flattenfields + create indextemplate #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
Issif
force-pushed
the
mapping-elasticsearch
branch
2 times, most recently
from
71311f7
to
0168768
Compare
fjogeleit
reviewed
Jun 19, 2024
outputs/elasticsearch.go
Outdated
| return err | ||
| } | ||
| d.EndpointURL = u | ||
| if err := d.Get(); err != nil { |
There was a problem hiding this comment.
this block has a very deep nesting, you could think about a dedicated function which uses early returns instead
There was a problem hiding this comment.
Got it. Just changed the func following your comment
Signed-off-by: Thomas Labarussias <[email protected]>
Issif
force-pushed
the
mapping-elasticsearch
branch
from
0168768
to
d083849
Compare
Signed-off-by: Thomas Labarussias <[email protected]>
fjogeleit
approved these changes
Jun 24, 2024
|
LGTM label has been added. Git tree hash: 2591bafdd035dc71148c99f7790ae2e1563f33df
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjogeleit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Allow to flatten the
output_fields(replace.by_) to avoid the conflicts of mappings.Which issue(s) this PR fixes:
#762
Fixes #
Special notes for your reviewer: