feat(alertmanager): fix labels for alertmanager #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Donnelly <[email protected]>
Issif
reviewed
May 2, 2024
Signed-off-by: Ben Donnelly <[email protected]>
Umaaz
commented
May 6, 2024
Signed-off-by: Ben Donnelly <[email protected]>
|
Can you fix the CI error please? |
will do - sorry I have been away. |
Signed-off-by: Ben Donnelly <[email protected]>
|
Is there anything else pending on this? I think it is ready. |
Issif
approved these changes
May 22, 2024
|
LGTM label has been added. Git tree hash: 16e88b5b39b3f1e7b86c41a55e932690fc53c149
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Umaaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
The labels used by alertmanager need to match the regex
[a-zA-Z_][a-zA-Z0-9_]*.When adding a custom rule to get the AWS session name the label passed in is
json.value[/user/extra/sessionName]which is currently passes out to alertmanager asjson_value_/user/extra/sessionNamewhich doesn't work in Alertmanager as the/are invalid.Special notes for your reviewer: