This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Update dependency resolve-url-loader to v3 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
farism
approved these changes
Sep 18, 2018
This was referenced Sep 18, 2018
This was referenced Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates dependency
resolve-url-loader(source) fromv2.3.1tov3.0.0Release Notes
3.0.0 Postcss
Compare Source
Features
Use
postcssparser by default. This is long overdue as the oldreworkparser doesn't cope with modern css.Lots of automated tests running actual webpack builds. If you have an interesting use-case let me know.
Breaking Changes
joinoption.rootoption to be set.Migrating
Initially set option
engine: 'rework'for parity with your existing build. Once working you can remove this option or setengine: 'postcss'explicitly.Retain
keepQueryoption if you are already using it.The
rootoption now has a different meaning. Previously it limited file search. Now it is the base path for absolute or root-relative URIs, consistent withcss-loader. If you are already using it you can probably remove it.If you build on Windows platform and your content contains absolute asset paths, then
css-loadercould fail. Therootoption here may fix the URIs before they get tocss-loader. Try to leave it unspecified, otherwise (windows only) set to empty stringroot: ''.This PR has been generated by Renovate Bot.