Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira Issues not linking to Epics #895

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Jira Issues not linking to Epics #895

merged 3 commits into from
Jan 27, 2023

Conversation

ted-faros
Copy link
Contributor

@ted-faros ted-faros commented Jan 27, 2023

Description

In #862, we constrained on_conflict.update_columns to the fields in the object. This was done to ensure that only the mentioned fields were updated. However, we did not include FK fields in the update_columns. This caused updates of FKs to omitted.

Fixes faros-ai/faros-community-edition#272

Type of change

  • Bug fix
  • New feature
  • Breaking change

1) add mergeBy test to ensure we group by null keys
1) minor change to test
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ted-faros ted-faros merged commit 3f962b4 into main Jan 27, 2023
@ted-faros ted-faros deleted the tt/fix-ce-task-fk branch January 27, 2023 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jira Issues not linking to Epics
2 participants