Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds QA models #245

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Adds QA models #245

merged 8 commits into from
Nov 8, 2022

Conversation

thomas-gerber
Copy link
Contributor

@thomas-gerber thomas-gerber commented Nov 3, 2022

Description

QA models.

Type of change

  • New feature (non-breaking change which adds functionality)

Open considerations

  1. Consistency with how we ported other models vs limiting drift with our SaaS schema
  • We keep doing indices on uid, dates and FKs and only those
  • We name fields without _ and instead camelCase (e.g. refreshedAt)
  • We do NOT name FK fields with _id suffix (e.g. pullRequest instead of 'pull_request_id`)
  1. jsonb fields
  • We deal with TestCaseCondition (TestCase.after and TestCase.before) the same way we dealt with statuses in V003
  • For CodeQuality fields that are all CodeQualityMeasure entities, we only expand on the value

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber thomas-gerber marked this pull request as ready for review November 4, 2022 15:22
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

canonical-schema/V010__create_qa.sql Outdated Show resolved Hide resolved
canonical-schema/V010__create_qa.sql Outdated Show resolved Hide resolved
canonical-schema/V010__create_qa.sql Outdated Show resolved Hide resolved
@tovbinm
Copy link
Contributor

tovbinm commented Nov 4, 2022

We should migrate SonarQube and XRay sources next to allow you to will in some of this data quickly, + update faros-events-cli to allow sending TestExecution events to CE

@thomas-gerber thomas-gerber merged commit de3a4de into main Nov 8, 2022
@thomas-gerber thomas-gerber deleted the qa_models branch November 8, 2022 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants