-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcov 1.4.3 total percentage does not respect ignored files #130
Comments
I'm experiencing a similar issue since upgrading to |
the same with 1.4.3 |
same for me, on 1.4.3 |
Is there any chance this will get fixed soon? |
This issue appears to have been introduced by #129. @nakiostudio this is affecting everyone who has to upgrade to Xcode 10. Could you take look at this? |
Hi all 👋 Thank you for your patience here, I hit a dead end trying to fix this issue. In order to make the code coverage reported by xcov match the one reported by Xcode I need to use the target coverage specified in the So there are two solutions really:
What do you peeps think? |
Keep ignored files support.
On Fri, Sep 14, 2018 at 16:09 Carlos Vidal ***@***.***> wrote:
Hi all 👋
Thank you for your patience here, I hit a dead end trying to fix this
issue.
In order to make the code coverage reported by xcov match the one reported
by Xcode I need to use the target coverage specified in the . xccovreport
file (which is based on lines coverage). If xcov computes the coverage
itself (so ignored files can be ignored) with function coverage then the
resulting coverage differs to Xcode's.
So there are two solutions really:
- Drop ignored files support.
- Go back to coverage based on function coverage and keep ignored
files support.
What do you peeps think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#130 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AO-2UUCMble5hg3hOv47T-OPI3CSwfplks5ua7iggaJpZM4UpkKe>
.
--
Best regards,
Marko Čičak
|
Thanks, @nakiostudio. Agreed, keep ignore support, the ignore support is important for us. We use Xcov in my workplace specifically because it provides us the ability to pull unnecessary data out of the report eg views which we don’t test. Just curious, is there a way where you can determine what to ignore, and if it is nothing, use the one that matches Xcode? If you’re ignoring files, the overall number won’t match Xcode anyway. |
Keep ignored files support. This is our main reason for using xcov. |
Keep ignored files support, or provide two total numbers at one time (one from xcode, one from xcov) |
Keep ignored files support |
Keep ignored files support please |
Please keep ignored files support Is there any workaround in place for getting coverage numbers that respect the ignored files at the moment? |
Keep ignored files support |
Please keep the ignored files support. |
Please keep ignored files support |
Hey guys, this is still present in 1.5.0, can we expect having that fix ? |
Please keep ignored files support. |
@nakiostudio seems people are pretty set on supporting ignored files. Do you have any updates for this? |
Thank you all for the feedback and patience. I’ve been away without access to a laptop for quite some time. I plan to tackle this next week preserving ignored files support and using the appropriate way of calculating coverage depending on the ignored files setting. I will keep you all posted. |
Hello! |
Any updates? |
Waiting anxiously! 👍 |
Just updated to latest 1.5.0 but the issue is still present. Any info on when this will be covered? Thanks! |
There's several open issues for this problem now. Looks like it regressed in 1.4.3 and haven't been fixed since? That's pretty bad, since the reporting is effectively null and void by including the ignored files. Some feedback on when/if this will be addressed would be nice. |
I am using Slather as temporary solution. It works with XCode 10.1 |
any updates? |
Is interesting to note that when using |
...also wait for updates. @nakiostudio keep us informed about any progress here:) Thanks! |
This PR solve the problem! |
@clausjoergensen yes, I'm using this PR as xcov lib: And now ignored coverage files are working. |
Version 1.6.0 still have the problem. |
Will get this fixed in the next release! 💪 |
Version 1.7.0 still exhibits the issue. |
Was anyone able to test the PR mentioned above? Looks like it's still open #144 |
This is a fix for a long-running issue where in a bid to bring xcov values closer to XCode’s report, file and folder exclusions were being ignored. i.e. Exclusions were always considered when calculating the total coverage percentage. This commit reverts 2c68bfb which introduced the issue. For more information see: fastlane-community#130
I'm using this (https://github.com/aksvenk/xcov/tree/coverage-percentage-fix) via: gem 'xcov', github: 'aksvenk/xcov', branch: 'coverage-percentage-fix' and it works great! |
I too tested, Works fine for me. @Zeta611 Can you please create MR to the main repo. |
@chinnasamymca Here it is: #170 :) |
Fixed by #170 |
Released in |
In xcov 1.4.3 files that are ignored in the .xcovignore file is included in the overall percentage calculation.
Tested this on 1.4.2 and it is working as expected.
The text was updated successfully, but these errors were encountered: