-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5x8 Font: Add most Latin-1 characters #15
base: master
Are you sure you want to change the base?
Conversation
a2f1b0e
to
2abe09f
Compare
2abe09f
to
91b7418
Compare
@fcambus Is this something you would consider for merge or rather not? |
@fcambus Sorry for bumping this again, but once per quarter is hopefully not too high-frequency, maybe it just got buried in other notifications :) Is this something that can be merged, or does it need more work or would you rather not merge it? Thanks! |
Sorry for the delay, I only recently resumed work on Spleen after a long break. Due to character size constraints, it is not possible to fit the glyphs from the Latin-1 Supplement Unicode block in a way which would be readable and respect the consistency of the other sizes, that's why they have been left out. I have tried in the past :) |
Yes, the upper case characters with diacritics are sized a bit smaller (vertically) than their non-diacritic versions (see the screenshot for all the characters in this PR). If it's not a good fit for submitting upstream, I can also just maintain this for myself downstream. |
Out of curiosity, what is your use case for this? I'm honestly not sure what the use case would be. The 5x8 variant was created for small OLED displays, typically for appliances control panels, which do not really need anything more than ASCII. |
Now most Latin-1 characters have a representation in the 5x8 font:
![Screenshot 2021-07-17 at 10 21 28](https://user-images.githubusercontent.com/135241/126030978-ef6e4338-7524-4b84-b052-67f6b1cc3e92.png)