Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #321 #322

Merged
merged 2 commits into from
Nov 21, 2021
Merged

fix #321 #322

merged 2 commits into from
Nov 21, 2021

Conversation

blockloop
Copy link
Contributor

I also removed some of your custom implementations of stdlib strings functions for consistency

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #322 (b7a1047) into master (7916fa6) will decrease coverage by 0.33%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   80.91%   80.57%   -0.34%     
==========================================
  Files           3        3              
  Lines         351      345       -6     
==========================================
- Hits          284      278       -6     
  Misses         43       43              
  Partials       24       24              
Impacted Files Coverage Δ
s3_file.go 81.48% <66.66%> (ø)
s3_fs.go 78.52% <100.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7916fa6...b7a1047. Read the comment docs.

@fclairamb
Copy link
Owner

Ok I'm going to force it. I guess that's what happens when we re-implement standard library functions 😬 .

@fclairamb fclairamb merged commit fa29bc3 into fclairamb:master Nov 21, 2021
@fclairamb
Copy link
Owner

Thank you very much @blockloop, sorry for the very late answer. I need to properly setup my github notifications.

@blockloop blockloop deleted the bjones/fix-321 branch January 18, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants