Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stat for bucket root #393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix stat for bucket root #393

wants to merge 2 commits into from

Conversation

lorenz
Copy link

@lorenz lorenz commented Jan 11, 2022

Currently afero-s3 doesn't let clients list the bucket root because a HEAD on it doesn't return a 404 unless the bucket itself doesn't exist which means the existing code assumed it was a file. The bucket root is a directory by definition though, so this exposes it as such.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (13198e5) to head (f83cb02).
Report is 408 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   81.44%   80.97%   -0.47%     
==========================================
  Files           3        3              
  Lines         345      347       +2     
==========================================
  Hits          281      281              
- Misses         40       41       +1     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenz
Copy link
Author

lorenz commented Dec 15, 2022

@fclairamb Could you have a look at this change? It's a three-line fix and I'm now getting private messages by people who also need it on how to integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants