updates

.golangci.yml

@@ -181,28 +181,37 @@ linters:
         - errchkjson
         - errname
         - errorlint
+        - execinquery
+        - exhaustive
+        # - exhaustruct --> Not convinced it's useful
         # - exhaustivestruct
         - exportloopref
         - funlen
-        # - gci
+        - forbidigo
+        - forcetypeassert
+        - gci
+        - ginkgolinter
         - gochecknoinits
+        - gochecksumtype
         # - gochecknoglobals
         - gocognit
         - goconst
         - gocritic
         - gocyclo
+        # - godot --> lots of not so useful changes
         - godox
         - goerr113
         - gofmt
         - goimports
         - gosimple
         # - golint --> revive
         - revive
-        # - gomnd
+        # - gomnd --> too much work
         - goprintffuncname
         - gosec
         - gosimple
         - govet
+        - grouper
         - ineffassign
         # - interfacer --> (deprecated)
         - lll

asciiconverter.go

@@ -10,6 +10,8 @@ type convertMode int8
 const (
 	convertModeToCRLF convertMode = iota
 	convertModeToLF
+
+	bufferSize = 4096
 )
 
 type asciiConverter struct {
@@ -19,7 +21,7 @@ type asciiConverter struct {
 }
 
 func newASCIIConverter(r io.Reader, mode convertMode) *asciiConverter {
-	reader := bufio.NewReaderSize(r, 4096)
+	reader := bufio.NewReaderSize(r, bufferSize)
 
 	return &asciiConverter{
 		reader:    reader,

client_handler.go

@@ -13,7 +13,7 @@ import (
 	log "github.com/fclairamb/go-log"
 )
 
-// HASHAlgo is the enumerable that represents the supported HASH algorithms
+// HASHAlgo is the enumerable that represents the supported HASH algorithms.
 type HASHAlgo int8
 
 // Supported hash algorithms
@@ -25,7 +25,7 @@ const (
 	HASHAlgoSHA512
 )
 
-// TransferType is the enumerable that represents the supported transfer types
+// TransferType is the enumerable that represents the supported transfer types.
 type TransferType int8
 
 // Supported transfer type

server.go

@@ -232,7 +232,8 @@ func (server *FtpServer) Serve() error {
 			// & https://github.com/fclairamb/ftpserverlib/pull/352#pullrequestreview-1077459896
 			// The temporaryError method should replace net.Error.Temporary() when the go team
 			// will have provided us a better way to detect temporary errors.
-			if ne, ok := err.(net.Error); ok && ne.Temporary() { //nolint:staticcheck
+			var ne net.Error
+			if errors.Is(err, ne) && ne.Temporary() { //nolint:staticcheck
 				if tempDelay == 0 {
 					tempDelay = 5 * time.Millisecond
 				} else {

server_test.go

@@ -2,7 +2,6 @@ package ftpserver
 
 import (
 	"errors"
-	"fmt"
 	"net"
 	"os"
 	"syscall"
@@ -18,8 +17,7 @@ func TestMain(m *testing.M) {
 	// we change the timezone to be able to test that MLSD/MLST commands write UTC timestamps
 	loc, err := time.LoadLocation("America/New_York")
 	if err != nil {
-		fmt.Printf("unable to set timezone: %v\n", err)
-		os.Exit(1)
+		panic(err)
 	}
 
 	time.Local = loc

transfer_pasv.go

@@ -164,7 +164,7 @@ func (c *clientHandler) handlePASV(_ string) error {
 		}
 	}
 
-	p := &passiveTransferHandler{
+	p := &passiveTransferHandler{ //nolint:forcetypeassert
 		tcpListener:   tcpListener,
 		listener:      listener,
 		Port:          tcpListener.Addr().(*net.TCPAddr).Port,

transfer_test.go

@@ -998,7 +998,7 @@ func TestPASVConnectionWait(t *testing.T) {
 		},
 	}
 
-	p := passiveTransferHandler{
+	p := passiveTransferHandler{ //nolint:forcetypeassert
 		listener: &testNetListener{
 			conn: &testNetConn{
 				remoteAddr: &net.TCPAddr{IP: nil, Port: 21}, // invalid IP