Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quoted, space separated, HASH parameters #459

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented May 29, 2024

I think this issue was originally reported here.

@syncplify confirmation that this patch is working as expected would be appreciated. Thank you

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (1586bde) to head (879a19a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   86.62%   86.68%   +0.06%     
==========================================
  Files          11       11              
  Lines        1712     1720       +8     
==========================================
+ Hits         1483     1491       +8     
  Misses        155      155              
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@fclairamb fclairamb merged commit bfb6dd6 into fclairamb:main Jun 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants