Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

types(index.d.ts): improved the type definitions #52

Merged
merged 1 commit into from
Mar 6, 2019
Merged

types(index.d.ts): improved the type definitions #52

merged 1 commit into from
Mar 6, 2019

Conversation

yxliang01
Copy link
Contributor

@yxliang01 yxliang01 commented Mar 4, 2019 •
edited
Loading

  • Corrected some definitions of types
  • Completed the possible keys for Visitor
  • Removed some types that only exist in the parsed object from ANTLR but not in the output of this library

Note: This PR introduced some style-related changes:

  • removed trailing spaces
  • indentation from 4 spaces to 2 spaces (consistent with this codebase)
  • double quote to single quote (consistent with this codebase)

This is an effort linked to issue #48

@yxliang01 yxliang01 mentioned this pull request Mar 4, 2019
Open
4 tasks
federicobond
federicobond approved these changes Mar 6, 2019
View reviewed changes
Copy link
Owner

@federicobond federicobond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@federicobond federicobond merged commit afc727b into federicobond:master Mar 6, 2019
@yxliang01 yxliang01 deleted the patch-2 branch March 6, 2019 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@federicobond federicobond federicobond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxliang01 @federicobond