Update required to get Parrot Mambo Bebop working

[jwvictor]

This field was undefined for whatever reason, so handled for that case. It still finds that the other ID starts with Mambo_ so not a huge deal, but caused it to crash with my device (Parrot Mambo Bebop Minidrone). Thought you might like the update.

[fetherston]

@jwvictor thanks for the update! However, please setup eslint in your text editor and fix the changes to match the repositories lint rules (Note the failing build step in github).

[fetherston]

The command "npm test" exited with 0.
1.55s$ ./node_modules/.bin/eslint-changes
/Users/travis/build/fetherston/npm-parrot-minidrone/lib/MiniDroneBtAdapter.js
  407:9   error  Expected space(s) after "if"                              keyword-spacing
  407:22  error  Missing space before opening brace                        space-before-blocks
  408:17  error  Expected indentation of 12 space characters but found 16  indent

[jwvictor]

@fetherston Thank you so much for having a look, would love to commit to your project even in some small form -- I have had so much fun with it already, I certainly owe you :) I don't write much JS so I'll grab a copy of eslint and resubmit the PR as soon as I can. Thanks again!

[jwvictor]

@fetherston put in the changes the linter was asking for, CI should pass but it's taking a while :) lemme know if there's any trouble!

[fetherston]

I don't have a Mambo Bebop, but I think there might be a more elegant way to fix this. What is the values of the peripheral.advertisement object at this line? Does peripheral.advertisement.localName start with Mambo_? Or something else?

If it's something else you can fix this by just adding it to DRONE_PREFIXES at the top of this class

[jwvictor]

localName was undefined at this point, but by defaulting localNameMatch to false it still caught it (presumably via the manufacturer match). I can print out the exact object when I get home if that'd help.

[jwvictor]

@fetherston It turns out what's happening is there are other (non-matching) devices in my house that have localName undefined. This causes an NPE on the .indexOf call. When the proper peripheral is actually found, localName is indeed defined and matches Mambo_. So, this is a general problem for any situation in which one tries to connect to the drone in the presence of other devices not broadcasting a localName. Thoughts?