-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skippable ipk & script generation #59
base: master
Are you sure you want to change the base?
Skippable ipk & script generation #59
Conversation
In some embedded distributions (like openembedded) argparse is not shipped with python installation, it would be better to wrap |
OK, I'll change it to use |
|
Done. Got rid of btw, since |
|
IMHO, it is inappropriate to change the interface depending on the Python version used. (i.e. Use command line options if 2.7 or later, use environment variables if 2.6 or before) There're already weird things happening in Python 3 support which needs to be fixed. Doing so further breaks the interface consistency between 2.6.X and 2.7.X apart, also yielding not-so-clean code. In the case of "introducing too much irrelevant code", the common solution is simple and pretty obvious: move those code into a separate module. But, if I understand correctly, this project is standalone (no 3rd part library) and single-filed on purpose, so newbies could easily use it. Therefore, it is destined to be including various irrelevant code as time goes on. If you still think this pull request unacceptable, feel free to close it. I'll keep this in my own fork instead. 😞 |
Added options
--no-sh
and--no-ipk
to skip the generation ofswjsq_wget.sh
andswjsq_0.0.1_all.ipk
. Without these options, the behavior is not changed.This is a feature requested in #34 and my daily usage 😄