Add type checks and typing #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 51.13% 52.74% +1.60%
==========================================
Files 9 9
Lines 440 474 +34
==========================================
+ Hits 225 250 +25
- Misses 215 224 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fizyk
force-pushed
the
typing
branch
4 times, most recently
from
6b122e6
to
fef7600
Compare
fizyk
force-pushed
the
typing
branch
4 times, most recently
from
a69ca2b
to
61e2042
Compare
fizyk
force-pushed
the
typing
branch
2 times, most recently
from
bf2b954
to
360fc0c
Compare
fizyk
force-pushed
the
typing
branch
2 times, most recently
from
7b5d97f
to
0c96949
Compare
fizyk
commented
Jan 5, 2021
| @@ -55,10 +59,10 @@ class and ``bind_engine`` function. | |||
| class classproperty: | |||
There was a problem hiding this comment.
it's problematic to type it properly. Maybe it could be rewritten from the properties actually...
| """Get human readable name, e.g.: `Foo Bar`.""" | ||
| return Column(Unicode(cls._max_slug_length), nullable=False) | ||
|
|
||
| def set_slug( | ||
| self, | ||
| candidate=None, | ||
| gen_digest=generate_random_digest, | ||
| inspect=sa_inspect, |
| gen_digest=generate_random_digest, | ||
| inspect=sa_inspect, | ||
| session=Session, | ||
| to_slug=slugify.slugify, |
fizyk
force-pushed
the
typing
branch
2 times, most recently
from
e08982c
to
563d74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.