Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GPU memory leak in TextPairRegressor #3490

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Fix GPU memory leak in TextPairRegressor #3490

merged 4 commits into from
Jul 13, 2024

Commits on Jul 9, 2024

  1. fix: memory leak in TextPairRegressor when embed_separately=False 

    keep reference to concatenated sentence that is created when not embedding data points separately in a DataPair. those embeddings are then able to be cleared in clear_embeddings, freeing the memory from GPU
    @MattGPT-ai
    MattGPT-ai committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    52c7b15 View commit details
    Browse the repository at this point in the history

  2. feat: improve exception handling in data classes

    @MattGPT-ai
    MattGPT-ai committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b534186 View commit details
    Browse the repository at this point in the history

  3. refactor: add type hints to relevant files

    @MattGPT-ai
    MattGPT-ai committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1a6f110 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix: memory leak in TextPairRegressor when embed_separately=False 

    same as fix for TextPairRegressor
    @MattGPT-ai
    MattGPT-ai committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    05622e6 View commit details
    Browse the repository at this point in the history