GH-3509: fix support metric #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGPT-ai
force-pushed
the
GH-3509-fix-support-metric
branch
2 times, most recently
from
c415e43
to
09108c0
Compare
|
I'm not sure what the error occurring is, it doesn't seem to be related to my changes but maybe you are familiar with it |
MattGPT-ai
force-pushed
the
GH-3509-fix-support-metric
branch
from
09108c0
to
aecc875
Compare
|
Looks like the test passed without me changing anything, so this should be ready for review |
alanakbik
reviewed
Aug 9, 2024
flair/nn/model.py
Outdated
| @@ -737,7 +743,8 @@ def _encode_data_points(self, sentences: List[DT], data_points: List[DT2]): | |||
|
|
|||
| return data_point_tensor | |||
|
|
|||
| def _mask_scores(self, scores, data_points): | |||
| def _mask_scores(self, scores: Tensor, data_points) -> Tensor: | |||
| """This appears to have not been fully implemented and simply returns scores.""" | |||
There was a problem hiding this comment.
In most models, scores are not masked, so the default implementation is to just return the scores. The SpanClassifier overwrites this method to account for "candidate lists". Anything not on these lists, will be masked.
alanakbik
requested changes
Aug 9, 2024
|
@MattGPT-ai thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3509
Also adds more type hinting and fixes mutable default arguments.