Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S&K Credits Music Broken/Unnecessary Duplicate Equates? #7

Open
MainMemory opened this issue Jan 10, 2021 · 1 comment
Open

S&K Credits Music Broken/Unnecessary Duplicate Equates? #7

MainMemory opened this issue Jan 10, 2021 · 1 comment

Comments

@MainMemory
Copy link

With the way the driver is currently set up, attempting to play the S&K credits theme will break the sound driver. This is because the equates used by the sound driver place the S&K credits music and the first sound effect on the same slot. Obviously this can be fixed by simply adjusting a few of these equates to be one higher than they are currently, but I'm wondering why we need them at all, when there are nearly identical ones in sonic3k.constants.asm. Is it just so the driver can be self-contained?

@flamewing
Copy link
Owner

Note what I did to mus_CreditsK definition on this commit to the S&K integration; this is still related to the split between music and SFX queues.

There are equates in the driver because when I wrote it, those equates did not exist in S3&K disassembly. Also, they won't necessarily exist in S1 or S2 disassemblies.

Although now that I think about it, I can probably check for the existence of those S1/S2/S&K equates using ifdef and do some sanity checks, such as the S&K credits song being among with the other songs.

flamewing added a commit that referenced this issue Jan 14, 2021
From S1/S2/S&K disassemblies, along with some sanity checks and
messages. Also make the driver work if the ring sound is not the first,
or if left and right ring sounds are not adjacent.

Related to issue #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants