Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co-maintain the package in conda-eda? #1

Open
proppy opened this issue Mar 22, 2022 · 19 comments
Open

co-maintain the package in conda-eda? #1

proppy opened this issue Mar 22, 2022 · 19 comments

Comments

@proppy
Copy link

proppy commented Mar 22, 2022

Thanks for working on this package!

We're maintaining a set of eda related packages at https://github.com/hdl/conda-eda and were also looking at packaging klayout (hdl/conda-eda#175).

What would you think of co-maintaining this package in the conda-eda repository? That could make it easier for users to install all eda related from one channel and allow all project to share the same continuous integration infrastructure for rebuilding and publishing packages.

Let me know what you think!

/cc @joamatab @mithro

@proppy proppy changed the title co-maintain the package in conda-eda co-maintain the package in conda-eda? Mar 22, 2022
@flaport
Copy link
Owner

flaport commented Mar 22, 2022

Hey @proppy that sounds good to me!

But as you can maybe see this project is still pretty experimental. I think I'll keep on working in this repository until the build recipe has stabilized a bit.

Once I'm happy with the recipe (GUI + python package, windows & linux), I'd be happy to contribute it to conda-eda!

@proppy
Copy link
Author

proppy commented May 26, 2022

another thing to consider could be to contribute the package to conda-forge.

I recently went thru the staging process for magic in https://github.com/conda-forge/staged-recipes, so I'm happy to help navigating it if needed.

@joamatab
Copy link

joamatab commented May 26, 2022 via email

@flaport
Copy link
Owner

flaport commented May 29, 2022

@proppy , yes, I'd love to add it to conda-forge. I once added my fdtd package to conda-forge, so I'm pretty aware on how to do it myself too. The main problem is still that I cannot seem to build the GUI for any other version than python 3.8 for now... That said, publishing the klayout python package (not the GUI) on the other hand is basically just a repackaging of the PyPI wheel, so that should not be too difficult (I hope). Maybe we should start with that.

@joamatab , you can just repackage your gdsfactory wheels as conda packages quite easily. You just have to make sure you don't have any hard dependencies (i.e. ImportError if not present) on non-conda packages (like klayout for now). I can walk you through it in one of our next meetings if you want.

@proppy
Copy link
Author

proppy commented May 30, 2022

The main problem is still that I cannot seem to build the GUI for any other version than python 3.8 for now.

Do you have some pointers on the issues you encountered? conda-forge builder seem to have pretty good support for building packages for multiple versions for python: https://anaconda.org/conda-forge/opencv/files

@saicharan0112
Copy link

saicharan0112 commented Jul 30, 2022

@flaport I tried installing the conda package but it removes openroad and yosys packages.. To reproduce this issue, try this -

bash> docker run -it conda/miniconda3
docker> conda install -c litex-hub yosys openroad open_pdks.sky130a magic netgen -y
docker> conda config --append channels conda-forge
docker> conda install -c flaport klayout -y

You would be seeing openroad and yosys under the removed packages list when you install the klayout package
image

@flaport
Copy link
Owner

flaport commented Jul 30, 2022

Hi @saicharan0112 ,

It seems that those two packages only exist for python 3.7

Currently my klayout builds only exist for python 3.8

Hence installing klayout will upgrade python and remove those two packages.

@flaport flaport closed this as completed Jul 30, 2022
@flaport flaport reopened this Jul 30, 2022
@saicharan0112
Copy link

@flaport Oh ok. So what could be the possible way if I want to keep both of them and install klayout?

@joamatab
Copy link

You can pip install klayout

Or sudo apt install klayout

@saicharan0112
Copy link

Yeah @joamatab , but the apt package manager version is at least 10 versions old. Current Klayout is 0.28 (github) but the package manager is still behind (0.26_2), if I am not wrong (https://packages.ubuntu.com/focal/klayout).. I am looking more into building the environment only with conda packages on a miniconda3 docker image.
However, I managed to go with the deb file from the website (Thanks to @proppy for the suggestion) on an ubuntu image but it would be good to have a conda package compatibility here.

https://github.com/saicharan0112/OpenFASOC/blob/main/docker/Dockerfile

@saicharan0112
Copy link

I don't know if it is a good idea to consider downgrading the current klayout package to python3.7 (or upgrading others to python3.8) just to have all tools running in a same environment since packages are really making things easy when it comes to installing tools in no time.

@proppy
Copy link
Author

proppy commented Aug 1, 2022

@flaport are you still open to co-maintain this package in conda-eda and/or conda-forge, there we could ensure it has a coherent environment with other related EDA packages?

@flaport
Copy link
Owner

flaport commented Aug 1, 2022

Hi @proppy , I'd love to hand over the project such that someone else can maintain it actually. Unfortunately I only got it to build for python 3.8 and I'm pretty much stuck for the other python versions. Feel free to give it a shot yourself ;-)

@msaligane
Copy link

@proppy @saicharan0112 any update on this?

@proppy
Copy link
Author

proppy commented Aug 30, 2022

@msaligane let's discuss in hdl/conda-eda#175 what it would take to maintain it in conda-eda.

@saicharan0112
Copy link

@flaport Can I know where you found these links?https://github.com/flaport/condalayout/blob/master/klayout-pypi-links.txt
By any chance, do you know where to find the pypi link for the 3.7 version?

@flaport
Copy link
Owner

flaport commented Sep 3, 2022

If I remember correctly I just went to pypi.org and right clicked 'copy url' the download links

@saicharan0112
Copy link

saicharan0112 commented Sep 3, 2022

@flaport Got it! And how did you manage to find the hash/link for different python versions for the same klayout version?

@saicharan0112
Copy link

Got it.. Its in the same location but need to scroll down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants